-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Enable X25519MLKEM768 as per draft-ietf-tls-ecdhe-mlkem #13656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Loganaden Velvindron <[email protected]> Signed-off-by: Devraj Appadu <[email protected]>
|
@songy23 it appears that the build system does not support golang 1.25 yet ?
|
Signed-off-by: Loganaden Velvindron <[email protected]> Signed-off-by: Devraj Appadu <[email protected]>
|
does this need a changelog? |
Signed-off-by: Loganaden Velvindron <[email protected]> Signed-off-by: Devraj Appadu <[email protected]>
How do I add one as it appears to be autogenerated ? |
They are not, please follow http://github.com/open-telemetry/opentelemetry-collector/blob/main/CONTRIBUTING.md#changelog |
Signed-off-by: Loganaden Velvindron <[email protected]> Signed-off-by: Devraj Appadu <[email protected]>
|
@songy23 Can you re-run the tests and we see if it passes ? |
Signed-off-by: Loganaden Velvindron <[email protected]> Signed-off-by: Devraj Appadu <[email protected]>
|
@songy23 i fixed the unit test. Let's see if it passes CI/CD now ? |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (87.63%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #13656 +/- ##
==========================================
- Coverage 87.66% 87.63% -0.04%
==========================================
Files 632 632
Lines 39697 39697
==========================================
- Hits 34802 34790 -12
- Misses 3651 3660 +9
- Partials 1244 1247 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
songy23
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not exactly sure if this warrants a changelog as I don't have much context here, but other than that LGTM
|
Signed-off-by: Loganaden Velvindron <[email protected]> Signed-off-by: Devraj Appadu <[email protected]>
|
@songy23 @bogdandrutu Done |
ee3fccc
Description
Enable X25519MLKEM768 as per draft-ietf-tls-ecdhe-mlkem
Fixes http://github.com/open-telemetry/opentelemetry-collector/issues/13670
Testing
Enable X25519MLKEM768 for testing