Skip to content

Conversation

@loganaden
Copy link
Contributor

@loganaden loganaden commented Aug 18, 2025

Description

Enable X25519MLKEM768 as per draft-ietf-tls-ecdhe-mlkem

Fixes http://github.com/open-telemetry/opentelemetry-collector/issues/13670

Testing

Enable X25519MLKEM768 for testing

Signed-off-by: Loganaden Velvindron <[email protected]>
Signed-off-by: Devraj Appadu <[email protected]>
@loganaden loganaden requested a review from a team as a code owner August 18, 2025 06:21
@loganaden loganaden requested a review from songy23 August 18, 2025 06:21
@loganaden
Copy link
Contributor Author

loganaden commented Aug 18, 2025

@bogdandrutu @dmathieu

@loganaden
Copy link
Contributor Author

@songy23 it appears that the build system does not support golang 1.25 yet ?

go: module ../../config/configtls requires go >= 1.25 (running go 1.24.6)

Signed-off-by: Loganaden Velvindron <[email protected]>
Signed-off-by: Devraj Appadu <[email protected]>
@loganaden loganaden requested a review from songy23 August 18, 2025 14:00
@songy23 songy23 added the ci-cd CI, CD, testing, build issues label Aug 18, 2025
@songy23
Copy link
Member

songy23 commented Aug 18, 2025

does this need a changelog?

@songy23 songy23 removed the ci-cd CI, CD, testing, build issues label Aug 18, 2025
Signed-off-by: Loganaden Velvindron <[email protected]>
Signed-off-by: Devraj Appadu <[email protected]>
@loganaden
Copy link
Contributor Author

does this need a changelog?

How do I add one as it appears to be autogenerated ?

@songy23
Copy link
Member

songy23 commented Aug 18, 2025

How do I add one as it appears to be autogenerated ?

They are not, please follow http://github.com/open-telemetry/opentelemetry-collector/blob/main/CONTRIBUTING.md#changelog

@songy23
Copy link
Member

songy23 commented Aug 18, 2025

Signed-off-by: Loganaden Velvindron <[email protected]>
Signed-off-by: Devraj Appadu <[email protected]>
@loganaden
Copy link
Contributor Author

@songy23 Can you re-run the tests and we see if it passes ?

Signed-off-by: Loganaden Velvindron <[email protected]>
Signed-off-by: Devraj Appadu <[email protected]>
@loganaden
Copy link
Contributor Author

@songy23 i fixed the unit test. Let's see if it passes CI/CD now ?

@loganaden loganaden requested a review from songy23 August 18, 2025 17:37
@codecov
Copy link

codecov bot commented Aug 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.63%. Comparing base (90cdf5f) to head (750c132).
⚠️ Report is 13 commits behind head on main.

❌ Your project status has failed because the head coverage (87.63%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13656      +/-   ##
==========================================
- Coverage   87.66%   87.63%   -0.04%     
==========================================
  Files         632      632              
  Lines       39697    39697              
==========================================
- Hits        34802    34790      -12     
- Misses       3651     3660       +9     
- Partials     1244     1247       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not exactly sure if this warrants a changelog as I don't have much context here, but other than that LGTM

@bogdandrutu
Copy link
Member

How do I add one as it appears to be autogenerated ?

make chlog-new

Signed-off-by: Loganaden Velvindron <[email protected]>
Signed-off-by: Devraj Appadu <[email protected]>
@loganaden
Copy link
Contributor Author

@songy23 @bogdandrutu Done

@songy23 songy23 linked an issue Aug 19, 2025 that may be closed by this pull request
@songy23 songy23 added the ready-to-merge Code review completed; ready to merge by maintainers label Aug 19, 2025
@bogdandrutu bogdandrutu added this pull request to the merge queue Aug 21, 2025
Merged via the queue into open-telemetry:main with commit ee3fccc Aug 21, 2025
73 of 76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Code review completed; ready to merge by maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable X25519MLKEM768

3 participants