Skip to content

Conversation

@atoulme
Copy link
Contributor

@atoulme atoulme commented Aug 10, 2025

Description

Memory limiter extension and processor shutdown don't throw an error if the component was not started first.

Link to tracking issue

Fixes #9687

@codecov
Copy link

codecov bot commented Aug 10, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.25%. Comparing base (185f7dd) to head (1f690ef).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
internal/memorylimiter/memorylimiter.go 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13599      +/-   ##
==========================================
- Coverage   92.26%   92.25%   -0.02%     
==========================================
  Files         614      614              
  Lines       33684    33684              
==========================================
- Hits        31079    31075       -4     
- Misses       2071     2074       +3     
- Partials      534      535       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atoulme atoulme requested a review from codeboten August 10, 2025 07:14
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @atoulme!

@codeboten codeboten added this pull request to the merge queue Aug 11, 2025
Merged via the queue into open-telemetry:main with commit 6716056 Aug 11, 2025
56 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lifecycle tests: memory limiter processor shutdown func needs fixing

2 participants