Skip to content

Conversation

matsvanmolle
Copy link
Collaborator

No description provided.

Signed-off-by: Mats Van Molle <[email protected]>
Signed-off-by: Mats Van Molle <[email protected]>
@matsvanmolle matsvanmolle requested a review from apaolillo May 2, 2025 12:12
@matsvanmolle matsvanmolle self-assigned this May 2, 2025
) -> Tuple[List[str], Dict[str, Dict[str, str]]]:
from subprocess import check_output

def shell_out(command, print_input=False, print_output=False):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be no reason to create another version of shell_out.
What was the reasoning behind this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than this, I see nothing wrong with the commit but I do hope that Ubuntu and other os quickly update their perf version, as somewhere in V6 they added the option to just output perf list to a JSON.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaronbog As you can see, the code you are referring to is outdated. It was there for debugging purposes, but I initially forgot to remove it. This was removed with 119e4e7.

@apaolillo
Copy link
Collaborator

I'm not comfortable with these changes as I don't know where exactly it was failing. Perhaps we need a proper grammar for perf-list instead of relying of a huge set of regexes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants