Skip to content

Added Generate Short URL example in Java #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Pooja444
Copy link
Contributor

@Pooja444 Pooja444 commented Oct 4, 2022

Github Issue

Closes: appwrite/appwrite#4191

Description

This change will add the example of generating a short URL using Java. The supported providers are [tinyurl, bitly]
This change also adds a README for deploying the code using docker.

Successful executions

Successful execution using bitly

Screen Shot 2022-10-04 at 3 24 00 PM

Successful execution using tinyurl

Screen Shot 2022-10-04 at 3 23 35 PM

Errors

Empty payload error

Screen Shot 2022-10-04 at 3 30 23 PM

Empty variables error

Screen Shot 2022-10-04 at 3 32 22 PM

Empty API key error

Screen Shot 2022-10-04 at 3 33 29 PM

No provider error

Screen Shot 2022-10-04 at 3 34 24 PM

No URL error

Screen Shot 2022-10-04 at 3 35 52 PM

Unsupported provider error

Screen Shot 2022-10-04 at 3 36 59 PM

Invalid URL error

Screen Shot 2022-10-04 at 3 38 20 PM

@Meldiron
Copy link
Contributor

Meldiron commented Oct 5, 2022

@Pooja444 , thanks for the PR! 🤯 Please give us some time to review it.

Copy link
Contributor

@Meldiron Meldiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great quality of Java code! 🤯 I left my review, a few small things need to be changed, but other than that, amazing PR. Once my PRs are addressed, I can mark this approved.

@Pooja444
Copy link
Contributor Author

Pooja444 commented Oct 7, 2022

@Meldiron thanks a lot for your comments! I have addressed them and made the required changes.

@Pooja444
Copy link
Contributor Author

Pooja444 commented Oct 7, 2022

Tested the changes too -

TinyUrl successful execution -

Screen Shot 2022-10-07 at 10 20 44 AM

Bitly successful execution -

Screen Shot 2022-10-07 at 10 20 04 AM

TinyUrl key not passed error -

Screen Shot 2022-10-07 at 10 21 02 AM

Bitly key not passed error -

Screen Shot 2022-10-07 at 10 22 10 AM

@Pooja444 Pooja444 requested a review from Meldiron October 7, 2022 17:37
Copy link
Contributor

@Meldiron Meldiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me 😇 🎉🎉🎉

@Pooja444
Copy link
Contributor Author

Pooja444 commented Oct 10, 2022

Thanks for approving it @Meldiron 😁

@christyjacob4 christyjacob4 merged commit d6d89cd into open-runtimes:main Oct 14, 2022
@christyjacob4
Copy link
Contributor

THANK YOU! All changes merged 🥳

Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord.  

You can accept the invite by visiting https://github.com/orgs/appwrite/invitation. By joining our team, you will officially be an Appwrite maintainer on GitHub.

You can change your membership visibility settings, so your new Appwrite team membership badge will show up on your personal GitHub profile.

Please feel free to look for more PRs you might be interested in helping with on our long list of Hacktoberfest friendly issues and help make Appwrite better :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⚡ Write a generateShortUrl() Function using Java
3 participants