switched cumproduct to cumprod in base_diffusion for numpy compliance + added utf8 compliance in update_model_index#518
Open
manaspgandhi wants to merge 1 commit intoopen-mmlab:masterfrom
Conversation
…, as well as changed a file open in update_model_index to utf8 compliance for windows machines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I am using mmgeneration for a stable diffusion model. I noticed some issues in the codebase that I changed to make it work, and wanted to make sure everyone could use the codebase without issues.
Modification