Skip to content

Conversation

hjy94wo777
Copy link

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Modify some typehints in csp_darknet.py.

Modification

Modify some typehints in csp_darknet.py.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@hjy94wo777
Copy link
Author

Sorry, I'm not sure how to write the doc string in the forward function

@ZwwWayne ZwwWayne assigned BIGWangYuDong and unassigned Czm369 Nov 29, 2022
@ZwwWayne ZwwWayne added this to the 3.0.0rc5 milestone Nov 29, 2022
@BIGWangYuDong
Copy link
Collaborator

BIGWangYuDong commented Nov 29, 2022

Sorry, I'm not sure how to write the doc string in the forward function

You can have a look at other models. A simple example here:

"""Forward function.

Args:
xxx

Returns:
Tensor:
"""

Copy link
Member

@RangiLyu RangiLyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your contribution! Please change the PR tile to the CodeCamp format!

@ZwwWayne
Copy link
Collaborator

Is there any progress?

@ZwwWayne
Copy link
Collaborator

Closed as it cannot be merged in to dev-3.x.

@ZwwWayne ZwwWayne closed this Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants