Skip to content

Conversation

@sahidvelji
Copy link
Contributor

@sahidvelji sahidvelji commented Jun 28, 2025

This PR

This PR removes the Status() method from the provider.

Related Issues

Related to #299

Notes

Follow-up Tasks

How to test

@codecov
Copy link

codecov bot commented Jun 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.76%. Comparing base (9908b97) to head (ac8b047).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #395      +/-   ##
==========================================
+ Coverage   85.64%   85.76%   +0.11%     
==========================================
  Files          20       20              
  Lines        1442     1440       -2     
==========================================
  Hits         1235     1235              
+ Misses        186      184       -2     
  Partials       21       21              
Flag Coverage Δ
e2e 85.76% <ø> (+0.11%) ⬆️
unit 85.76% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sahidvelji sahidvelji marked this pull request as ready for review June 28, 2025 00:12
@sahidvelji sahidvelji requested review from a team as code owners June 28, 2025 00:12
Copy link
Member

@aepfli aepfli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[question] is this breaking? Could this be expected somewhere?

Anyways thank you for your continuous efforts!!!!!

@sahidvelji
Copy link
Contributor Author

[question] is this breaking? Could this be expected somewhere?

It is theoretically breaking, yes. Practically speaking though, I can't imagine many users querying the status of a noop provider via noopProvider.Status() anywhere. The Status method on providers is definitely not expected anywhere in this SDK though. There is no interface that requires it, and a search for "status" across the repo doesn't turn up anything notable.

@beeme1mr beeme1mr merged commit b9cc78b into open-feature:main Jun 29, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants