Add BNO channels to stream, and update stream/channel identifiers#32
Conversation
aacuevas
left a comment
aacuevas
left a comment
There was a problem hiding this comment.
Please fix the channel definitions with the proper scaling and please add the units to the channels using the methods that Josh suggested. Even if they are not used yet by the LFP, it's better if this processor produces the correct data already
aacuevas
left a comment
aacuevas
left a comment
There was a problem hiding this comment.
Apart from the memory comment and the possibility of making bno calibration an event, seems ok
| "Hardware buffer usage", | ||
| "rhythm-fpga-device.continuous.mem", | ||
| 1.0f, //some scaling so it does not overflow too easily | ||
| "acq-board.memory.continuous", |
There was a problem hiding this comment.
I just thought, maybe call this continuous.percentage ?
just to be clear on what this entails
Also, can you add the unit as percentage?
|
@aacuevas regarding the calibration status issue, I have made a new issue describing the potential solutions here, feel free to take a look at it and add any more details you think might be relevant. To continue with testing, I will push the memory identifier changes, but we can work on the calibration issue at a later time. |
2 participants
Fixes #29
Fixes #30