-
Notifications
You must be signed in to change notification settings - Fork 458
gha: Skip non-relevant checks on pr or merge_group #4684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gha: Skip non-relevant checks on pr or merge_group #4684
Conversation
d9c5312 to
318f9f9
Compare
23eb25f to
e2144f6
Compare
e2144f6 to
5cf5bbf
Compare
a4699f7 to
958e5a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Optimizes GitHub Actions workflows by introducing conditional execution based on file changes and consolidating security scans. The PR restructures existing workflows to avoid running unnecessary checks when irrelevant files are modified, adds merge_group triggers, and separates security scanning into a dedicated workflow.
- Added file path checking to conditionally run workflow jobs based on changed files
- Introduced merge_group triggers and consolidated security scans into a separate workflow
- Added required_check jobs to aggregate workflow results for proper status reporting
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/ui-lint-and-test.yaml | Added conditional execution based on file changes and required status check aggregation |
| .github/workflows/pr-security-scan.yaml | New dedicated workflow for security scans on pull requests |
| .github/workflows/lib-lint-and-test.yaml | Restructured with conditional execution and moved security scans to separate workflow |
| .github/workflows/build.yaml | Added file change detection and improved PR comment conditions |
| .github/workflows/backend-lint-and-test.yaml | Added conditional execution with path checking and required status aggregation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
958e5a4 to
d08d8f2
Compare
leoll2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, ty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This reverts commit 85ed8df.
Summary
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.