feat(inspect): Train model dialog rework #3225
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…improved UI Signed-off-by: Dmitry Kalinin <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reworks the train model dialog to use new model metadata and updated UX, including the addition of a max epochs field. The changes modernize the dialog's appearance and improve the model selection experience by introducing recommended models, enhanced model information display, and device selection improvements.
Key changes:
- Introduced model metadata including families, performance metrics, and recommendations
- Added max epochs configuration field with contextual help
- Refactored device selection into a dedicated component with improved UX
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| application/ui/src/features/inspect/train-model/types.ts | Defines TypeScript types for model families, performance metrics, and trainable models with display name mappings |
| application/ui/src/features/inspect/train-model/training-device-picker.component.tsx | New component for device selection with custom hook for device management and fallback UI for no devices |
| application/ui/src/features/inspect/train-model/trainable-model-list-box.component.tsx | Refactored to display models in cards with show more/less functionality for recommended vs other models |
| application/ui/src/features/inspect/train-model/trainable-model-card.component.tsx | New card component displaying model details including name, family tags, metrics, and documentation links |
| application/ui/src/features/inspect/train-model/model-tag.component.tsx | Simple tag component for displaying model categories with variant styling |
| application/ui/src/features/inspect/train-model/model-metrics-display.component.tsx | Component displaying training/inference speed metrics and parameter count with gauge icons |
| application/ui/src/features/inspect/train-model/train-model.module.scss | Updated styles for the new card-based model selection UI with tags and improved visual hierarchy |
| application/ui/src/features/inspect/train-model/train-model-dialog.component.tsx | Updated dialog to include max epochs field and integrate new device picker component |
| application/ui/src/features/inspect/train-model/utils/device-metadata.test.ts | Tests for device preference selection logic |
| application/ui/src/features/inspect/train-model/trainable-model-list-box.test.tsx | Tests for model filtering and show more/less functionality |
| application/ui/src/features/inspect/train-model/train-model-dialog.test.tsx | Integration tests for dialog form validation and submission |
| application/ui/mocks/mock-trainable-models.ts | Mock data factory for trainable models used in tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
application/ui/src/features/inspect/train-model/training-device-picker.component.tsx
Outdated
Show resolved
Hide resolved
application/ui/src/features/inspect/train-model/training-device-picker.component.tsx
Outdated
Show resolved
Hide resolved
…e-picker.component.tsx Co-authored-by: Copilot <[email protected]> Signed-off-by: Dmitry Kalinin <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
application/ui/src/features/inspect/train-model/model-metrics-display.component.tsx
Outdated
Show resolved
Hide resolved
application/ui/src/features/inspect/train-model/trainable-model-list-box.component.tsx
Show resolved
Hide resolved
Signed-off-by: Dmitry Kalinin <[email protected]>
| docs_url: 'https://anomalib.readthedocs.io/', | ||
| recommended: true, | ||
| parameters: 27, | ||
| metrics: { |
Contributor
There was a problem hiding this comment.
Based on the feedback, can we remove the metrics?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
The train model dialog was updated to use the new model metadata and updated UX.
Closes 📋 [TASK] Geti Inspect: Improve train model dialog #3175
✨ Changes
Select what type of change your PR is:
✅ Checklist
Before you submit your pull request, please make sure you have completed the following steps:
For more information about code review checklists, see the Code Review Checklist.