Skip to content

Conversation

@djdameln
Copy link
Contributor

📝 Description

  • This fixes the performance difference between single- and multi-gpu setups.

Causes of the problem:

  • Failure to correctly reduce the internal metric states of the MinMax metrics between devices.
    • Solution: Set dist_reduce_fx to appropriate method when defining states in MinMax value.
  • Wrong use of metric state in F1AdaptiveThreshold (metric states should not be used to store final value).
    • Solution: Remove computed value as internal state and register the value as a buffer in the PostProcessor instead.

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔨 Refactor (non-breaking change which refactors the code base)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔒 Security update

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📋 I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@codecov
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.62%. Comparing base (084331d) to head (7d3a8ab).
Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (084331d) and HEAD (7d3a8ab). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (084331d) HEAD (7d3a8ab)
1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2499       +/-   ##
===========================================
- Coverage   78.94%   64.62%   -14.33%     
===========================================
  Files         311      311               
  Lines       13197    13183       -14     
===========================================
- Hits        10419     8519     -1900     
- Misses       2778     4664     +1886     
Flag Coverage Δ
unit_py3.10 64.62% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samet-akcay samet-akcay enabled auto-merge (squash) January 14, 2025 11:28
@samet-akcay samet-akcay merged commit 8d14ae1 into open-edge-platform:main Jan 14, 2025
10 checks passed
@djdameln djdameln mentioned this pull request Jan 17, 2025
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants