Skip to content

Exit with error in BDBA scan if uploaded/scanned file seems to be empty #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
8R0WNI3 merged 1 commit into from
Dec 5, 2025
Merged

Exit with error in BDBA scan if uploaded/scanned file seems to be empty #629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions bdba/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,8 @@ class AnalysisResult(Result):
fail_reason: str | None
components: list[Component] = dataclasses.field(default_factory=list)
custom_data: dict[str, str] = dataclasses.field(default_factory=dict)
binary_bytes: int | None
scanned_bytes: int | None


@dataclasses.dataclass
Expand Down
7 changes: 7 additions & 0 deletions bdba_utils/scan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,13 @@ def process(
logger.error(f'scan of {scanned_element=} failed; {scan_result=}')
return

if not (scan_result.binary_bytes and scan_result.scanned_bytes):
logger.error(
f'scan of {scanned_element=} failed: uploaded or scanned file is empty '
f'({scan_result.binary_bytes=}, {scan_result.scanned_bytes=})'
)
return

logger.info(
f'scan of {scan_result.display_name} succeeded, going to post-process results'
)
Expand Down