Skip to content

Enable support to ONNX 1.15. #2279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Dec 21, 2023
Merged

Enable support to ONNX 1.15. #2279

merged 25 commits into from
Dec 21, 2023

Conversation

fatcat-z
Copy link
Collaborator

@fatcat-z fatcat-z commented Dec 20, 2023 •
edited
Loading

In ONNX 1.15 version, the helper.make_attribute() method doesn't allow to accept an empty list unless the value of attr_type is given as well. 'attr_type' is a new attribute introduced in ONNX 1.15.

In same cases, tf2onnx may add an empty list as an attribute to a newly created ONNX node. This fix will handle this situation in ONNX 1.15 and lower versions for compatibility.

Fix #2280

fatcat-z and others added 23 commits December 6, 2023 17:15
@fatcat-z
Add attr_type for empty sequence attribute.
8a7663c
@fatcat-z
Do not use strict mode while checking node shape.
9bc47c1 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Change the way to set node name. (#2278)
af20d58 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Process attributes to avoid empty iterator error.
9d37c41 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Update the comments.
dbe002b 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Check if attr_type is in signature of make_attribute.
147d727 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Update tests to see if the fix works.
9ebc7a9 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Correct the ONNX version.
0d9fdaf 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Merge branch 'main' into support_onnx_1_15
8f19a41 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Add a condiction when we try to remove a transpose node. (#2272)
4917e59 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Add attr_type for empty sequence attribute.
1e928e7 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Do not use strict mode while checking node shape.
bda86cb 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Change the way to set node name. (#2278)
f44b60e 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Process attributes to avoid empty iterator error.
473750c 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Update the comments.
2e73ed0 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Check if attr_type is in signature of make_attribute.
a569ca1 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Update tests to see if the fix works.
35a06b5 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Correct the ONNX version.
d143e72 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Merge branch 'support_onnx_1_15' of https://github.com/fatcat-z/tenso…
80663de 
…rflow-onnx into support_onnx_1_15
@fatcat-z
Fix lint error.
57b73a1 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Fix a lint error.
f8cdd55 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Missing a keyword.
ced05d7 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Update tests to upgrade onnx to 1.15.0 in CI.
b907699 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z fatcat-z marked this pull request as ready for review December 21, 2023 02:20
@fatcat-z fatcat-z requested a review from xiaowuhu December 21, 2023 02:20
@fatcat-z
Code refactor.
fb130bf 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
FIx a lint issue.
74bcffc 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z fatcat-z mentioned this pull request Dec 21, 2023
Open
@fatcat-z fatcat-z enabled auto-merge (squash) December 21, 2023 05:01
@fatcat-z fatcat-z merged commit e177a26 into onnx:main Dec 21, 2023
@fatcat-z fatcat-z deleted the support_onnx_1_15 branch January 16, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaowuhu xiaowuhu xiaowuhu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TF2ONNX doesn't support ONNX 1.15.0.
2 participants
@fatcat-z @xiaowuhu