Skip to content

tf-2.6.0 -> tf-2.6.1 to avoid build issues #1759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2021

Conversation

guschmue
Copy link
Contributor

@guschmue guschmue commented Nov 2, 2021

Signed-off-by: Guenther Schmuelling [email protected]

Signed-off-by: Guenther Schmuelling <[email protected]>
@guschmue
Copy link
Contributor Author

guschmue commented Nov 3, 2021

problem that this PR fixes is that we pinned to tf-2.6.0 and when tf-2.6.1 was released some of the submodules are pulled as tf-2.6.1 which broke ci.

@leimao
Copy link
Contributor

leimao commented Nov 3, 2021

@guschmue Thank you.

Copy link
Contributor

@leimao leimao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guschmue
Copy link
Contributor Author

guschmue commented Nov 3, 2021

In your ci/setup step I can see that we are pip installing tf-2.5 but end up with tf-2.6.1 for some reason. Might be a fluke - I let me re-run the failed tests for your and see if it will pass now.

@leimao
Copy link
Contributor

leimao commented Nov 4, 2021

@TomWildenhain-Microsoft Could you please review and approve this? Thank you.

@TomWildenhain-Microsoft TomWildenhain-Microsoft merged commit 03c643a into master Nov 5, 2021
@TomWildenhain-Microsoft TomWildenhain-Microsoft deleted the gs/tf-vers branch November 5, 2021 00:31
@leimao
Copy link
Contributor

leimao commented Nov 5, 2021

@TomWildenhain-Microsoft In fact that there are many CI errors for this merge request. But the GitHub interface failed to show them. We thought this merge request fixed everything but it did not.

Please see:
https://dev.azure.com/tensorflow-onnx/tensorflow-onnx/_build/results?buildId=15941&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants