Skip to content

Handle Mul as Square in TransposeOptimizer #1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 15, 2021
Merged

Handle Mul as Square in TransposeOptimizer #1339

merged 2 commits into from
Feb 15, 2021

Conversation

mateusztabaka
Copy link
Contributor

Signed-off-by: Mateusz Tabaka [email protected]

@mateusztabaka
Copy link
Contributor Author

@TomWildenhain-Microsoft please review

@TomWildenhain-Microsoft TomWildenhain-Microsoft merged commit 4224f40 into onnx:master Feb 15, 2021
@TomWildenhain-Microsoft
Copy link
Collaborator

@mateusztabaka thanks for the improvements to transpose optimization! Is there a particular model you are trying to improve performance on?

@mateusztabaka
Copy link
Contributor Author

There are couple of models I'm working on, but unfortunately I can't share the details.

@TomWildenhain-Microsoft
Copy link
Collaborator

No problem. If you are trying to improve perf, you might find this profiling tool useful:
https://github.com/microsoft/onnxconverter-common/blob/4f4940d8e23c996dc16245d1b9747956ff61e9a0/onnxconverter_common/perfstats.py

@mateusztabaka
Copy link
Contributor Author

Thanks. I will try it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomWildenhain-Microsoft TomWildenhain-Microsoft TomWildenhain-Microsoft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mateusztabaka @TomWildenhain-Microsoft