transpose optimizer wrongly removes a transpose #1288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: guschmue <[email protected]>
| @@ -462,7 +462,7 @@ def __init__(self, nodes, output_shapes=None, dtypes=None, target=None, opset=No | |||
| self._output_to_consumers = {} | |||
| self._input_to_graph = {} | |||
| self.shapes = {} | |||
| self.graph_name = graph_name or "tf2onnx" | |||
| self.graph_name = graph_name or utils.make_name("tf2onnx") | |||
There was a problem hiding this comment.
Did you determine the cause of the identical names issue?
There was a problem hiding this comment.
yes, its the main graph that is set to 'tf2onnx' when writing the onnx file, which is actually what we want.
TomWildenhain-Microsoft
approved these changes
Jan 22, 2021
Signed-off-by: guschmue <[email protected]>
Signed-off-by: guschmue <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: guschmue [email protected]
fix for #1277
transpose optimizer wrongly removes a transpose when trying to push to none existing subgraph.