Skip to content

Fix flaky async request modifier test #2456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
onevcat merged 1 commit into from
Dec 18, 2025
Merged

Fix flaky async request modifier test #2456

onevcat merged 1 commit into from
Dec 18, 2025
+10 −12

Conversation

@onevcat
Copy link
Owner

@onevcat onevcat commented Dec 18, 2025 •
edited
Loading

Fixes an occasional CI failure in ImageDownloaderTests.testDownloadWithAsyncModifyingRequest caused by a race between Task {} scheduling (used only to flip a flag) and the download completion callback.

The test now uses two expectations and waits with enforceOrder: true so that downloadTaskStarted must be fulfilled before downloadCompleted.

@onevcat onevcat merged commit 681ab68 into master Dec 18, 2025
24 checks passed
@onevcat onevcat deleted the fix/flaky-async-modifier-test branch December 18, 2025 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@onevcat