Compatibility for Rider 2021.2-EAP

[greuelpirat]

I just updated to Rider 2021.2-EAP, which is not supported by your plugin:

Are there issues or is it just a version-check?

[olsh]

Hi @greuelpirat,

Well, honestly, I don't know if there are issues with the new SDK. I didn't manage to upgrade SDK to EAP because of Gradle build, and I don't have time to investigate the problem, sorry.

PR is welcome.

[greuelpirat]

@olsh
I checked it out. But I could not build it successfully. There are some dependencies which seems to not have been published yet. I retry it later.

[mterwoord]

Now that 2021.2 is RTM ( a few hours..), any update on this? :-)

[greuelpirat]

Ui, i completly forgot about this :-(

I tried again, but I must admit, that I do not know enough about plugin development to get it work. I have no idea what Zone requirements are not consistent across modules means. Sorry, but I have not the time to work at this.

[olsh]

Hi guys, I don't have a Windows PC right now. So I'm unable to test/build the plugins.
I get Windows PC only in two-three weeks.
PR is welcome.

I've tried to build the plugins without manual testing with AppVeyor, but no success yet.
#40

[LarsBauer]

Are there any TODOs apart from updating the jetbrains NuGet packages? I could submit a PR.

[mterwoord]

Probably fixing remaining issues. I think the message @greuelpirat already mentioned.

[olsh]

Are there any TODOs apart from updating the jetbrains NuGet packages? I could submit a PR.

At least the code should compile and all tests should pass without issues.

[LarsBauer]

I upgraded the NuGet packages and the local build was successful. The tests won't run locally so I tried via pipeline (#41). Now there is some kind of gradle error. Any idea?

Edit:
It looks like gradle is looking for version 2021.2.0 while there is only version 2021.2 available in the repos. Thats tricky because version is passed to gradle via Directory.Build.Props.

And JetBrains is not very consistent in versioning...

[olsh]

Hi @LarsBauer

Thank you for your PR.
I believe that we can do Trim('0', '.') for -PProductVersion parameter here

resharper-structured-logging/build/Build.cs

Line 127 in f7ac19c

Gradle($"buildPlugin -PPluginVersion={ExtensionVersion} -PProductVersion={SdkVersion} -PDotNetOutputDirectory={OutputDirectory} -PDotNetProjectName={Project.Name}", customLogger:

[LarsBauer]

Thanks, this helped with building the project. Now we are facing some test errors. Unfortunately I have no experience regarding JetBrain Plugin tests. Can someone have a look?

[klemmchr]

Since Rider 2021.2 is now stable, do you have any updates on this?

[jiilaa]

I took a look at the failing tests, and it looks like the .cs.gold-files which the tests compare, no long matches the test output. Some of the lines are different because the test output has <overlapped> added to the beginning of the lines and the order of some warnings has changed. I'm not familiar with Rider plugin tests either, so I can't be sure if it is a proper fix to change the .cs.gold files to match the output or is this an indication that the plugin has a problem with the new Rider and needs actual fixing.

I hope someone can fix this soon, this is a really useful plugin for me :-)

[deleteLater]

from https://www.jetbrains.com/rider/whatsnew/

it seems like the Rider 2021.2 has shipped this feature

[mterwoord]

Awesome. How could I miss this? Thanks for finding this out!