Skip to content

Conversation

@ParthSareen
Copy link
Member

and also change attribute to string

@ParthSareen ParthSareen requested a review from mxyng December 6, 2024 19:02
Copy link
Member

@jmorganca jmorganca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ParthSareen ParthSareen merged commit 70dd0b7 into main Dec 8, 2024
@ParthSareen ParthSareen deleted the parth/fix-so-example branch December 8, 2024 04:01
@tdiprima
Copy link

tdiprima commented Dec 9, 2024

Needs additional fixing. Please see PR #370

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants