fix(containers): embed distribution configs as OCI labels on published images#6121
Merged
cdoern merged 1 commit intoJun 15, 2026
Merged
Conversation
…d images The config label embedding added previously only ran in local builds (scripts/docker.sh) and the verify-only build-distributions.yml workflow, which builds with --load and never pushes. The images actually published to DockerHub are built by the publish-docker-images job in pypi.yml, which never generated or applied the labels, so published images carry none. Generate the labels with the existing scripts/generate-config-labels.sh and pass them to docker/build-push-action via its labels input so pushed images embed the distribution configs. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Charlie Doern <cdoern@redhat.com>
franciscojavierarceo
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The OCI config-label embedding added in #5460 only takes effect in two places:
scripts/docker.sh— local dev builds.github/workflows/build-distributions.yml— a verify-only workflow that builds with--loadand never pushesThe container images that are actually published to DockerHub
(
distribution-<distro>:<tag>) are built by thepublish-docker-imagesjob in.github/workflows/pypi.yml, which never generated or applied the labels. As aresult, the published/pulled images carry no embedded distribution configs.
This wires label generation into that publish job: it runs the existing
scripts/generate-config-labels.shand passes the result todocker/build-push-actionvia itslabels:input.Changes
.github/workflows/pypi.yml: add aGenerate config labelsstep to thepublish-docker-imagesjob and pass the output to the build/push action.The script emits alternating
--label/key=valuelines for the docker CLI;build-push-actionwants barekey=valuelines, so the flag lines are stripped.Notes
starter,postgres-demo) arepublished by this workflow, so those are the images that gain labels.
(via the
docker_only/skip_latestworkflow_dispatch inputs, run from thematching release ref) to gain labels retroactively.
Test plan
scripts/generate-config-labels.sh starter <version> | grep -v '^--label$'produces clean
key=valuepairs, which is the formatbuild-push-action'slabels:input expects.🤖 Generated with Claude Code