Fix mobile breadcrumb html safe #9
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsdeus
changed the title
rsdeus
changed the title
froger
reviewed
Nov 26, 2024
| <span> | ||
| <% breadcrumb_items.last(2).each_with_index do |item, i| %> | ||
| <% item_label = decidim_escape_translated(item[:label]) %> | ||
| <% item_label = decidim_escape_translated(item[:label]).html_safe %> |
Member
There was a problem hiding this comment.
@rsdeus decidim_escape_translated, shouldn't always be html_safe? or add a param to the function.
Member
There was a problem hiding this comment.
I see the function applied in numerous places: https://github.com/search?q=repo%3Adecidim%2Fdecidim+decidim_escape_translated&type=code&p=1
And I see no reference to html_safe... meaning the issue is potentially everywhere?
Member
Author
There was a problem hiding this comment.
Yes, but the problems do not arise everywhere. However, I suggested returning the output of decidim_html_escape with html_safe to ensure better encoding.
87bd217
rsdeus
force-pushed
the
fix/mobile_breadcrumb_html_safe
branch
from
4118060 to
6e5b605
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rsdeus
force-pushed
the
fix/mobile_breadcrumb_html_safe
branch
from
6e5b605 to
f4145fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Breadcrumb for mobile is escaped without html_safe, and for desktop, it is displayed without using the escape method.
📌 Related Issues
https://git.octree.ch/decidim/decidim-nightly/-/issues/68#note_46918
Testing
Create an proposal named, for example: "Partage d'idées"
📷 Screenshots