Create devcontainer for a more complete code spaces implementation #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce we get our release branch green again.
kfcampbell
approved these changes
Sep 28, 2022
There was a problem hiding this comment.
The configuration seems reasonable to me. I've confirmed that starting a codespace on this branch and running dotnet test properly and successfully executes the test suite. On main, we get output like the following:
Testhost process exited with error: You must install or update .NET to run this application.
App: /home/codespace/.nuget/packages/microsoft.testplatform.testhost/16.5.0/lib/netcoreapp2.1/testhost.dll
Architecture: x64
Framework: 'Microsoft.NETCore.App', version '3.1.0' (x64)
.NET location: /usr/local/dotnet/6/
The following frameworks were found:
6.0.9 at [/usr/local/dotnet/6/shared/Microsoft.NETCore.App]
Learn about framework resolution:
https://aka.ms/dotnet/app-launch-failed
To install missing framework, download:
https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=3.1.0&arch=x64&rid=ubuntu.20.04-x64
. Please check the diagnostic logs for more information.
Test Run Aborted.
Octokit.GraphQL.UnitTests -> /workspaces/octokit.graphql.net/Octokit.GraphQL.UnitTests/bin/Debug/netcoreapp3.1/Octokit.GraphQL.UnitTests.dll
Test run for /workspaces/octokit.graphql.net/Octokit.GraphQL.UnitTests/bin/Debug/netcoreapp3.1/Octokit.GraphQL.UnitTests.dll (.NETCoreApp,Version=v3.1)
Microsoft (R) Test Execution Command Line Tool Version 17.3.0 (x64)
Copyright (c) Microsoft Corporation. All rights reserved.
Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
Testhost process exited with error: You must install or update .NET to run this application.
App: /home/codespace/.nuget/packages/microsoft.testplatform.testhost/16.5.0/lib/netcoreapp2.1/testhost.dll
Architecture: x64
Framework: 'Microsoft.NETCore.App', version '3.1.0' (x64)
.NET location: /usr/local/dotnet/6/
The following frameworks were found:
6.0.9 at [/usr/local/dotnet/6/shared/Microsoft.NETCore.App]
Learn about framework resolution:
https://aka.ms/dotnet/app-launch-failed
To install missing framework, download:
https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=3.1.0&arch=x64&rid=ubuntu.20.04-x64
. Please check the diagnostic logs for more information.
Test Run Aborted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When spinning up a code spaces instance with this repo the dev still has to install and configure the .NET and omnisharp aspects so that things like
dotnet runanddotnet testoperate as expected.I missed this in my initial pass on all of the SDK repos.