Skip to content

Conversation

jcansdale
Copy link
Collaborator

@jcansdale jcansdale commented Nov 12, 2020

What this PR does

  • Uncomment OrganizationVerifiedDomainEmails method
  • Add integration test for OrganizationVerifiedDomainEmails

Add test for @MichaelDenwood's #245.

@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #246 (3e5be32) into master (56b5b05) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #246   +/-   ##
=======================================
  Coverage   78.83%   78.83%           
=======================================
  Files          73       73           
  Lines        2447     2447           
  Branches      357      357           
=======================================
  Hits         1929     1929           
  Misses        441      441           
  Partials       77       77           

@jcansdale
Copy link
Collaborator Author

Hi @MichaelDenwood,

If you have a moment, could you sanity check this PR?

Copy link
Contributor

@MichaelDenwood MichaelDenwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jcansdale
Copy link
Collaborator Author

@MichaelDenwood thanks again for your fix! Merging this PR now.

@jcansdale jcansdale merged commit 835c571 into master Nov 12, 2020
@jcansdale jcansdale deleted the jcansdale/OrganizationVerifiedDomainEmails branch November 12, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants