Fix stack overflow when using DateTimeOffset params #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding support for DTO in the serialize method.
Codecov Report
@@ Coverage Diff @@
## master #214 +/- ##
==========================================
+ Coverage 79.25% 79.28% +0.02%
==========================================
Files 73 73
Lines 2473 2476 +3
Branches 354 355 +1
==========================================
+ Hits 1960 1963 +3
Misses 436 436
Partials 77 77
|
jcansdale
approved these changes
Mar 4, 2020
|
Can this be merged and released please? |
|
Sorry for the wait @LordJZ -- circling back on the PR now. |
Forcing policy re-evaluation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a "watermark" (e.g. updatedAt) as a predicate to a query, the library produces stack overflow exceptions because it repeatedly tries to serialize the same object. There should probably be an additional change to make sure that that loop doesn't happen and throw a StackOverflow, maybe instead saying "Serializing this type is not supported".
Any tips on where I should put the testing for this would be helpful, it looks like this class doesn't have unit tests specific to just it.