Skip to content

Fix Dom_html.Keyboard_code.of_event #1878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2025
Merged

Fix Dom_html.Keyboard_code.of_event #1878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96cdf7e
Fix Dom_html.Keyboard_code.of_event
vouillon Mar 13, 2025
7a10574
Merge branch 'master' into keycode-fix
TyOverby Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,11 @@
* Compiler: fix stack overflow issues with double translation (#1869)
* Compiler: minifier fix (#1867)
* Compiler: fix assert failure with double translation (#1870)
* Lib: fix Dom_html.Keyboard_code.of_event (#1878)
* Runtime: fix Int64.of_string overflow check (#1874)
* Runtime: fix caml_string_concat when not using JS strings (#1874)


# 6.0.1 (2025-02-07) - Lille

## Features/Changes
Expand Down
2 changes: 1 addition & 1 deletion lib/js_of_ocaml/dom_html.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3383,7 +3383,7 @@ module Keyboard_code = struct
| 1 -> run_next (get_key_code evt) try_key_code_left
| 2 -> run_next (get_key_code evt) try_key_code_right
| 3 -> run_next (get_key_code evt) try_key_code_numpad
| _ -> make_unidentified
| _ -> fun v -> v

let ( |> ) x f = f x

Expand Down
Loading