Jump Custom Request Client Implementation#1654
Merged
smorimoto merged 14 commits intoocamllabs:masterfrom Nov 29, 2024
Merged
Conversation
voodoos
reviewed
Nov 26, 2024
Collaborator
|
Could you please move the changelog entry to unreleased section? |
voodoos
reviewed
Nov 27, 2024
Collaborator
voodoos
left a comment
voodoos
left a comment
There was a problem hiding this comment.
Thanks Pizie, looks good. I made a few comments / tweaks suggestions.
Co-authored-by: Ulysse <5031221+voodoos@users.noreply.github.com>
Co-authored-by: Ulysse <5031221+voodoos@users.noreply.github.com>
Co-authored-by: Ulysse <5031221+voodoos@users.noreply.github.com>
smorimoto
approved these changes
Nov 28, 2024
voodoos
reviewed
Nov 28, 2024
voodoos
reviewed
Nov 28, 2024
Co-authored-by: Ulysse <5031221+voodoos@users.noreply.github.com>
voodoos
approved these changes
Nov 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Advanced Navigation
Introduction
This PR implements the Jump Custom Requests.
UI
Jump results are displayed in a QuickPick component where upon selection, the jump is made to the selected target.
UX
This command can be triggered from the command pallet or with the keyboard binding
Alt +JNotifications
Ocamllsp warning: Ifocamllspis not running at the time the command is invoked, this notification is displayed.No support for requests: If the version of ocamllsp doesn't publish theocamllsp/jumpcapability then this notification is displayed.Commands
One command is published
ocaml.jumpwhich triggers the process.Demo
vscode.jump.mp4
References
cc @voodoos