Inherit top-comment from @inline includes #654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julow
force-pushed
the
toplevel-doc-comment-inc
branch
from
32144f3 to
36c279f
Compare
Julow
force-pushed
the
toplevel-doc-comment-inc
branch
from
36c279f to
2f3e919
Compare
|
Rebased and ready for review. |
A signature starting with an `include` with the `@inline` tag that doesn't have a top-comment inherits the top-comment from the included module type.
{!modules:...} lists are resolved when linking, code can't be shared
with the generator because types are different too.
Julow
force-pushed
the
toplevel-doc-comment-inc
branch
from
2f3e919 to
0171d8e
Compare
|
Just rebased :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally closes #478 (this is the last remaining issue).
A signature starting with an
includewith the@inlinetag that doesn't have a top-comment inherits the top-comment from the included module type.On top of #647. It's changing unrelated code but the expanded documentation would be rendered twice otherwise.