Fix placement of preamble in module alias expansions #606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julow
force-pushed
the
module_preamble_hidden_module
branch
from
d2814ee to
b5ef6e4
Compare
|
As with #595 , merging for the tests, expecting to revisit this code soon. |
Previously, when resolving module aliases, the documentation of the target module was inserted in the signature as a Comment.
Julow
force-pushed
the
module_preamble_hidden_module
branch
from
b5ef6e4 to
8522725
Compare
|
Just fixed the conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #328
Somewhere deep in
xref2, the documentation of a module was inserted into the signature when resolving module aliases. This PR propagate the doc comment through resolving.