Remove mdx #591
Merged
Remove mdx #591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll re-enable them after we've split the parser out of odoc and removed the cyclic dependency with mdx. Signed-off-by: Jon Ludlam <[email protected]>
This was failing in the github actions tests, as bisect_ppx 2.6.0 has a test dependency on ocamlformat 0.16.0, which has a dependency on odoc. I assume ocaml-ci doesn't install test dependencies for the main project dependencies. Another problem due to the ocamldoc comment parser being part of odoc. Signed-off-by: Jon Ludlam <[email protected]>
The esy workflow was failing to find the odoc binary, despite having built it. I'm unsure what the cause of this is, and the workaround is suspicious, but does seems to work. Signed-off-by: Jon Ludlam <[email protected]>
|
It'd be really useful to get someone more familiar with esy to check this over - in particular this seemed suspect to me. |
Julow
reviewed
Feb 16, 2021
.github/workflows/build.yml
Outdated
| @@ -104,4 +94,4 @@ jobs: | |||
| run: esy install --verbose | |||
|
|
|||
| - name: Build odoc | |||
| run: esy odoc --version | |||
| run: esy x dune exec src/odoc/bin/main.exe -- --version | |||
There was a problem hiding this comment.
This doesn't seem right. I managed to make it work with this: Julow@cd8fb9b (esy build result)
There was a problem hiding this comment.
That looks much better - thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mdx currently requires the comment parser that is part of odoc, and until this commit, odoc required mdx as a test dependeny. This PR is to remove odoc's dependency on mdx until the parser can be extracted into a separate repository. The intention is to re-add the mdx requirement as soon as the circular dependency problem is resolved, hence I have left disabled dune files in place where that made sense.