Improve location of some custom operators#1917
Open
WardBrian wants to merge 6 commits intoocaml:mainfrom
Open
Conversation
Contributor
Author
|
Fuzzy CI diff looks all intentional to me |
Collaborator
|
Thanks for the patch @WardBrian. I will review it when I get some spare cycles (it might take some time..). |
Contributor
Author
|
@voodoos gentle ping -- is there still interest in this being looked at? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This (maybe?) closes #1915.
It adds the same test as #1916, plus a:
:=( .@(;..)<- ))DOTOP SEMI DOTDOT ...and detect it in the driver codeDOTOPin the wild, we assume it is single-indexing without assignment and complete it accordingly. E.g., the codename.@( (* whatever here ... *)will get turned into.@ ( )by reconstruct_id, even if we'd like to also detect things like;or<-to disambiguate.The test shows both the cases that don't work before (see existing output in #1917) and the cases that "work" but produce incorrect locations due to the third bullet point above.