feat(dune_lang): format multi-line strings#13758
Draft
Alizter wants to merge 1 commit intoocaml:mainfrom
Draft
Conversation
Alizter
force-pushed
the
push-kxrkwxtlkorp
branch
from
71caf09 to
7c16a47
Compare
Alizter
force-pushed
the
push-kxrkwxtlkorp
branch
from
7c16a47 to
736212e
Compare
Alizter
force-pushed
the
push-kxrkwxtlkorp
branch
from
736212e to
241c9af
Compare
Collaborator
Author
|
I think I will iterate on this a bit further, I'm still not happy with it myself. But others are welcome to take a look. |
This change adds support for preserving multi-line block strings ("\|"
and "\>" syntax) when formatting dune files with version >= 3.23.
For dune-lang < 3.23, block strings are converted to:
- Regular escaped strings (if no pforms)
- Templates (if pforms present, to preserve expansion semantics)
Supersedes ocaml#10780 and ocaml#11581.
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
force-pushed
the
push-kxrkwxtlkorp
branch
from
241c9af to
9f52c4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds support for preserving multi-line block strings ("|" and ">" syntax) when formatting dune files with version >= 3.23.
For dune-lang < 3.23, block strings are converted to:
Supersedes #10780 and #11581.