Skip to content

Conversation

hhugo
Copy link
Collaborator

@hhugo hhugo commented Jul 26, 2024

corresponding PR ocsigen/js_of_ocaml#1594

The next release of Js_of_ocaml will be able to do some cross-module/cross-library optimization. Dune needs to be explicit about additional dependencies.

@hhugo
Copy link
Collaborator Author

hhugo commented Jun 11, 2025

@vouillon, can you take a look ?

@vouillon
Copy link
Member

@hhugo As far as I understand the code, we are only reading shapes from cma files, not from cmo files. Should we use Compilation_context.dep_graphs for that?

@hhugo
Copy link
Collaborator Author

hhugo commented Jun 19, 2025

@hhugo As far as I understand the code, we are only reading shapes from cma files, not from cmo files. Should we use Compilation_context.dep_graphs for that?

I've just pushed the fix.

@hhugo
Copy link
Collaborator Author

hhugo commented Jun 26, 2025

@vouillon, can you review this again ? I've addressed your comments.

@hhugo
Copy link
Collaborator Author

hhugo commented Jul 4, 2025

ping @vouillon

@hhugo
Copy link
Collaborator Author

hhugo commented Jul 8, 2025

@rgrinberg, this is ready

@rgrinberg rgrinberg enabled auto-merge (squash) July 9, 2025 21:59
@hhugo hhugo added this to the 3.20 milestone Jul 10, 2025
hhugo added 3 commits July 16, 2025 18:30
Signed-off-by: Hugo Heuzard <[email protected]>
Signed-off-by: Hugo Heuzard <[email protected]>
Signed-off-by: Hugo Heuzard <[email protected]>
@rgrinberg rgrinberg merged commit 0153f76 into ocaml:main Jul 16, 2025
1 of 2 checks passed
@hhugo hhugo deleted the jsoo-shape2 branch July 16, 2025 18:34
Sudha247 pushed a commit to Sudha247/dune that referenced this pull request Jul 23, 2025
* Add support for jsoo shapes

Signed-off-by: Hugo Heuzard <[email protected]>

* read shapes for cmo.js

Signed-off-by: Hugo Heuzard <[email protected]>

* accept diff

Signed-off-by: Hugo Heuzard <[email protected]>

---------

Signed-off-by: Hugo Heuzard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants