-
Notifications
You must be signed in to change notification settings - Fork 444
Jsoo shapes #10767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jsoo shapes #10767
Conversation
c6cd81e
to
aa79af2
Compare
4ce62d0
to
7548f3d
Compare
@vouillon, can you take a look ? |
@hhugo As far as I understand the code, we are only reading shapes from |
I've just pushed the fix. |
@vouillon, can you review this again ? I've addressed your comments. |
ping @vouillon |
@rgrinberg, this is ready |
Signed-off-by: Hugo Heuzard <[email protected]>
Signed-off-by: Hugo Heuzard <[email protected]>
Signed-off-by: Hugo Heuzard <[email protected]>
* Add support for jsoo shapes Signed-off-by: Hugo Heuzard <[email protected]> * read shapes for cmo.js Signed-off-by: Hugo Heuzard <[email protected]> * accept diff Signed-off-by: Hugo Heuzard <[email protected]> --------- Signed-off-by: Hugo Heuzard <[email protected]>
corresponding PR ocsigen/js_of_ocaml#1594
The next release of Js_of_ocaml will be able to do some cross-module/cross-library optimization. Dune needs to be explicit about additional dependencies.