Skip to content

Fix ml_z_remove w.r.t. GC rules #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2021
Merged

Fix ml_z_remove w.r.t. GC rules #108

merged 1 commit into from
Nov 20, 2021

Conversation

xclerc
Copy link
Contributor

@xclerc xclerc commented Nov 18, 2021 •
edited
Loading

(This is joint work with @mshinwell.)

The Field(...) = allocating_expression statement
is likely unsafe, so this pull request simply goes through
a temporary variable.

xavierleroy
xavierleroy approved these changes Nov 20, 2021
View reviewed changes
Copy link
Contributor

@xavierleroy xavierleroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, there is a potential bug here.

@xavierleroy xavierleroy merged commit 661849f into ocaml:master Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavierleroy xavierleroy xavierleroy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xclerc @xavierleroy