linux-capture: Implement EGL backend for xcomposite capture #6474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkartaltepe
force-pushed
the
xcompcap-egl
branch
2 times, most recently
from
da3ec65 to
ec66b45
Compare
kkartaltepe
added
Enhancement
|
I have this in WIP since its dependent on the rewrite but its fairly well tested and should be basically done. |
|
This needs manual rebase |
kkartaltepe
changed the title
|
Thanks for the merge :) rebased and removed wip. |
GeorgesStavracas
requested changes
May 14, 2022
This updates glad for EGL and adds in several extensions. EGL_EXT_platform_base EGL_EXT_platform_xcb EGL_KHR_image_base EGL_KHR_image_pixmap The xcb platform extension is unused but good to include if we want to try removing more Xlib dependencies. platform_base is included for good measure as other platform extensions technically build on it. image_base and image_pixmap are for upcoming xcomposite over EGL support. It also drops the unused create_context_no_error extensions.
create_texture_from_pixmap is only implemented for X11/EGL where it will bind the provided X11 pixmap to a texture with glEGLImageTargetTexture2DOES
When running on EGL we can use the new create_texture_from_pixmap functions to implement xcomposite capture. This removes the texture indirection previously implemented for GLX due to not using the spriting functionality in the built in shaders. Now that we texture directly from the pixmap we can remove the red/blue swap workarounds.
GeorgesStavracas
force-pushed
the
xcompcap-egl
branch
from
7de875d to
0c57bee
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables us to provide xcomposite capture when running on X11 on EGL and makes minor improvements to GLX implementation.
Right now its rebased on the xcomposite rewrite but that should be merged soon and ill rebase this.
Motivation and Context
Some drivers (such as nvidia) have very limited functionality for pixmap capture such as only allowing a single mapping. On popular compositors such as gnome they capture before OBS has started and so users are unable to capture windows. However these drivers dont have such a restriction when using the EGL extensions, which makes the user experience more pleasant.
How Has This Been Tested?
Tested on nvidia and intel. Everything seems to be working as expected but we have some extra code for software renders like LLVMPipe which I have not tested on the newer GLX setup or EGL.
Types of changes
Checklist: