fix: Add embed prefix for Apple Notes attachments and scans#516
Open
heyalchang wants to merge 1 commit intoobsidianmd:masterfrom
Open
fix: Add embed prefix for Apple Notes attachments and scans#516heyalchang wants to merge 1 commit intoobsidianmd:masterfrom
heyalchang wants to merge 1 commit intoobsidianmd:masterfrom
Conversation
heyalchang
force-pushed
the
fix/apple-notes-embed-prefix
branch
from
461fb76 to
03fcb5a
Compare
generateMarkdownLink() produces a link, but attachments and scans need the ! embed prefix to render inline. Without it, images and PDFs appear as links instead of inline embeds. The third generateMarkdownLink call in getInternalLink() is left unchanged — it produces note-to-note links, not embeds. Addresses obsidianmd#471
heyalchang
force-pushed
the
fix/apple-notes-embed-prefix
branch
from
03fcb5a to
5937e54
Compare
Contributor
|
Note this issue is due to a breaking change in Obsidian 1.10.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
!prefix is missing from the generated markdown link!prefix in bothconvert-note.ts(attachments) andconvert-scan.ts(scans/drawings)generateMarkdownLinkcall ingetInternalLink()is intentionally left unchanged — it produces note-to-note links ([[note]]), not embedsThis matches Apple Notes' own behavior where all attachments are rendered inline.
Test plan
[[filename.jpg]]text links[[note]]links, not embedsAddresses #471 (item 3: attachments not embedded inline)