Skip to content

build(deps): add resourceprocessor #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2024
Merged

build(deps): add resourceprocessor #94

merged 1 commit into from
Sep 24, 2024

Conversation

obs-gh-alexlew
Copy link
Collaborator

@obs-gh-alexlew obs-gh-alexlew commented Sep 23, 2024

Description

OB-36942 Add resource processor

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

Copy link
Collaborator

@xueweiz xueweiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha I see now how it's done. Basically:

  1. add dependency in go.mod
  2. go mod vendor stuff
  3. register it in components.go explicitly

Curious, how did you generate the README.md update? (If there is an instruction documented somewhere, a link would be perfect)

(Next time if I need something, I can try not to bother you writing it out and just ask you to review it

@obs-gh-alexlew
Copy link
Collaborator Author

There's instructions on updating the component here: https://github.com/observeinc/observe-agent?tab=readme-ov-file#adding-new-components

its actually a little complicated since we need to add it to the manifest and then install the ocb tool and use that in the makefile command to generate the new files and move them to the right places. The README.md i'm manually updating by hand using https://www.tablesgenerator.com/markdown_tables

@obs-gh-alexlew obs-gh-alexlew merged commit 97a83d7 into main Sep 24, 2024
8 checks passed
@obs-gh-alexlew obs-gh-alexlew deleted the alew/ob-36942 branch September 24, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants