Skip to content

fix: make config file noreplace for rpm #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2025

Conversation

obs-gh-alexlew
Copy link
Collaborator

Description

OB-XXX Please explain the changes you made here.

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

.goreleaser.yaml Outdated
@@ -172,7 +172,7 @@ nfpms:

- src: packaging/linux/config/observe-agent.service
dst: /lib/systemd/system/observe-agent.service
type: config
type: config|noreplace
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we do want to replace the service file, but want this change above for packaging/linux/config/observe-agent.yaml

@obs-gh-alexlew obs-gh-alexlew merged commit 8d715cc into main Jun 24, 2025
12 checks passed
@obs-gh-alexlew obs-gh-alexlew deleted the alew/rpm-no-replace-config branch June 24, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants