feat: support otelcol flags (config, set, feature-gates) in all sub commands #216
Conversation
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
obs-gh-mattcotter
force-pushed
the
mc/config-flag
branch
4 times, most recently
from
725da6e to
42bd381
Compare
| ) | ||
|
|
||
| // TODO enable this test once the agent bundled configs don't depend on the host filesystem having the templates. | ||
| func XTest_RenderOtelConfig(t *testing.T) { |
There was a problem hiding this comment.
maybe we should have some sort of unit test mode that looks for the templates somewhere relative to current path vs. somewhere specific on the FS. im fine with just looking at linux and not adding yet another copy of everything
There was a problem hiding this comment.
Updated! It was a pretty small change to the connections package. I had it use mac since that's how I do my dev work, but this is super easy to configure. I added a TODO to replace our snapshot tests with this new method; it will speed up the loop considerably.
| var otelSets []string | ||
|
|
||
| func AddConfigFlags(flags *pflag.FlagSet) { | ||
| flags.StringSliceVar(&otelConfigs, configFlag, []string{}, configFlagDescription) |
There was a problem hiding this comment.
what does this actually do? does it just register these flags?
There was a problem hiding this comment.
Yes, it registers the flags and provides storage for their values somewhere accessible to this package. I couldn't add them in root without introducing a circular dependency, and I think it's also a pro to have them scoped only to here so they don't get referenced elsewhere.
obs-gh-mattcotter
force-pushed
the
mc/config-flag
branch
from
42bd381 to
0ecb86e
Compare
…ime error happens in the otel collector
Description
OB-40550: Support otelcol flags (
config,set, andfeature-gates) in all sub commands. Substitutes of the listed otel flags are now configured at the root command level on the observe-agent and are applied to all subcommands.