add feature flag and parallelism config to PRWE #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
internal/commands/start/start.go
Outdated
| @@ -86,6 +86,9 @@ collector on the current host.` | |||
| for _, path := range originalConfigs { | |||
| configFlag.Value.Set(path) | |||
| } | |||
| // Set PRWE enable multiple workers feature gate. | |||
| EnableMultipleWritersFlag := otleCmd.Flags().Lookup("feature-gates") | |||
There was a problem hiding this comment.
Is there a reason to start the name with an upper case E? I think lower case would be more conventional.
Comment on lines
100
to
102
| remote_write_queue: | ||
| num_consumers: 10 | ||
| max_batch_request_parallelism: 10 |
There was a problem hiding this comment.
This is set to 10 but the helm chart uses 5 for both of these values. I think it's better to be consistent unless I'm missing something
obs-gh-mattcotter
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OB-XXX Please explain the changes you made here.
Checklist