-
Notifications
You must be signed in to change notification settings - Fork 1
feat: add snapshot tests for bundled config #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Orca Security Scan Summary
Status | Check | Issues by priority | |
---|---|---|---|
![]() |
Infrastructure as Code | ![]() ![]() ![]() ![]() |
View in Orca |
![]() |
SAST | ![]() ![]() ![]() ![]() |
View in Orca |
![]() |
Secrets | ![]() ![]() ![]() ![]() |
View in Orca |
![]() |
Vulnerabilities | ![]() ![]() ![]() ![]() |
View in Orca |
53e01e2
to
7641175
Compare
compression: zstd | ||
endpoint: https://123456789.collect.observe-eng.com/v2/otel | ||
headers: | ||
authorization: Bearer abcdefghijklmnopqrst:OWt0SXV4YTlqYUhpSHZjSlhXUDVkRXpl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there some way to mark to orca that this isn't a real credential? i feel like it might complain although the tests seem to pass now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@obs-gh-nikhildua do you know if this is possible? Maybe we can figure that out if it ever does complain?
how did the snapshots get generated currently? and when am I expected to update these? |
Good question! I started each file as identical copies of the output of the config command on my mac, then I ran the tests and applied the diff. I looked at the output at the end, and it's what I would expect. For updating this, whenever we modify our bundled config or add more observe-agent config options we may expect some diffs here. This test is supposed to make it easy to tell when our bundled config changes and to make sure we always consider that during code reviews. It won't say if the change is good or expected, that's up to the reviewers, but it will always flag a change which should catch mistakes. |
7641175
to
f17c328
Compare
4664fdb
to
b15da7c
Compare
Description
OB-45143 Add snapshot tests for the full bundled config in our test environments. This will catch when the observe-agent's provided otel config changes.
Checklist