Skip to content

fix: add nop receiver and exporter pipelines for count to ensure the connector is always valid #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions builder-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ exporters:
- gomod: go.opentelemetry.io/collector/exporter/debugexporter v0.124.0
- gomod: go.opentelemetry.io/collector/exporter/otlpexporter v0.124.0
- gomod: go.opentelemetry.io/collector/exporter/otlphttpexporter v0.124.0
- gomod: go.opentelemetry.io/collector/exporter/nopexporter v0.124.0

- gomod: github.com/open-telemetry/opentelemetry-collector-contrib/exporter/fileexporter v0.124.0
- gomod: github.com/open-telemetry/opentelemetry-collector-contrib/exporter/loadbalancingexporter v0.124.0
Expand Down Expand Up @@ -36,6 +37,7 @@ processors:

receivers:
- gomod: go.opentelemetry.io/collector/receiver/otlpreceiver v0.124.0
- gomod: go.opentelemetry.io/collector/receiver/nopreceiver v0.124.0

- gomod: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/awsecscontainermetricsreceiver v0.124.0
- gomod: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/dockerstatsreceiver v0.124.0
Expand Down
2 changes: 2 additions & 0 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,7 @@ require (
go.opentelemetry.io/collector/exporter/debugexporter v0.124.0 // indirect
go.opentelemetry.io/collector/exporter/exporterhelper/xexporterhelper v0.124.0 // indirect
go.opentelemetry.io/collector/exporter/exportertest v0.124.0 // indirect
go.opentelemetry.io/collector/exporter/nopexporter v0.124.0 // indirect
go.opentelemetry.io/collector/exporter/otlpexporter v0.124.0 // indirect
go.opentelemetry.io/collector/exporter/otlphttpexporter v0.124.0 // indirect
go.opentelemetry.io/collector/exporter/xexporter v0.124.0 // indirect
Expand Down Expand Up @@ -380,6 +381,7 @@ require (
go.opentelemetry.io/collector/processor/processortest v0.124.0 // indirect
go.opentelemetry.io/collector/processor/xprocessor v0.124.0 // indirect
go.opentelemetry.io/collector/receiver v1.30.0 // indirect
go.opentelemetry.io/collector/receiver/nopreceiver v0.124.0 // indirect
go.opentelemetry.io/collector/receiver/otlpreceiver v0.124.0 // indirect
go.opentelemetry.io/collector/receiver/receiverhelper v0.124.0 // indirect
go.opentelemetry.io/collector/receiver/receivertest v0.124.0 // indirect
Expand Down
6 changes: 6 additions & 0 deletions observecol/components.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions observecol/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ require (
go.opentelemetry.io/collector/connector/forwardconnector v0.124.0
go.opentelemetry.io/collector/exporter v0.124.0
go.opentelemetry.io/collector/exporter/debugexporter v0.124.0
go.opentelemetry.io/collector/exporter/nopexporter v0.124.0
go.opentelemetry.io/collector/exporter/otlpexporter v0.124.0
go.opentelemetry.io/collector/exporter/otlphttpexporter v0.124.0
go.opentelemetry.io/collector/extension v1.30.0
Expand All @@ -71,6 +72,7 @@ require (
go.opentelemetry.io/collector/processor/batchprocessor v0.124.0
go.opentelemetry.io/collector/processor/memorylimiterprocessor v0.124.0
go.opentelemetry.io/collector/receiver v1.30.0
go.opentelemetry.io/collector/receiver/nopreceiver v0.124.0
go.opentelemetry.io/collector/receiver/otlpreceiver v0.124.0
)

Expand Down
12 changes: 12 additions & 0 deletions packaging/docker/observe-agent/connections/common/base.yaml.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ extensions:
connectors:
count:

receivers:
nop:

processors:
# Snowflake limit for identifiers: Regardless of whether an identifier is unquoted or double-quoted, the maximum number of characters allowed is 255 (including blank spaces).
# https://docs.snowflake.com/en/sql-reference/identifiers-syntax#identifier-requirements
Expand Down Expand Up @@ -96,6 +99,15 @@ exporters:
send_metadata: true

debug:
nop:

service:
pipelines:
metrics/count-nop-in:
receivers: [nop]
exporters: [count]
metrics/count-nop-out:
receivers: [count]
exporters: [nop]

extensions: [health_check, file_storage]
12 changes: 12 additions & 0 deletions packaging/linux/connections/common/base.yaml.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ extensions:
connectors:
count:

receivers:
nop:

processors:
# Snowflake limit for identifiers: Regardless of whether an identifier is unquoted or double-quoted, the maximum number of characters allowed is 255 (including blank spaces).
# https://docs.snowflake.com/en/sql-reference/identifiers-syntax#identifier-requirements
Expand Down Expand Up @@ -96,6 +99,15 @@ exporters:
send_metadata: true

debug:
nop:

service:
pipelines:
metrics/count-nop-in:
receivers: [nop]
exporters: [count]
metrics/count-nop-out:
receivers: [count]
exporters: [nop]

extensions: [health_check, file_storage]
12 changes: 12 additions & 0 deletions packaging/macos/connections/common/base.yaml.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ extensions:
connectors:
count:

receivers:
nop:

processors:
# Snowflake limit for identifiers: Regardless of whether an identifier is unquoted or double-quoted, the maximum number of characters allowed is 255 (including blank spaces).
# https://docs.snowflake.com/en/sql-reference/identifiers-syntax#identifier-requirements
Expand Down Expand Up @@ -96,6 +99,15 @@ exporters:
send_metadata: true

debug:
nop:

service:
pipelines:
metrics/count-nop-in:
receivers: [nop]
exporters: [count]
metrics/count-nop-out:
receivers: [count]
exporters: [nop]

extensions: [health_check, file_storage]
12 changes: 12 additions & 0 deletions packaging/windows/connections/common/base.yaml.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ extensions:
connectors:
count:

receivers:
nop:

processors:
# Snowflake limit for identifiers: Regardless of whether an identifier is unquoted or double-quoted, the maximum number of characters allowed is 255 (including blank spaces).
# https://docs.snowflake.com/en/sql-reference/identifiers-syntax#identifier-requirements
Expand Down Expand Up @@ -76,6 +79,15 @@ exporters:
send_metadata: true

debug:
nop:

service:
pipelines:
metrics/count-nop-in:
receivers: [nop]
exporters: [count]
metrics/count-nop-out:
receivers: [count]
exporters: [nop]

extensions: [health_check, file_storage]
Loading
Loading