feat: add config option to set service explorer attributes #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
obs-gh-mattcotter
force-pushed
the
mc/agent-attributes
branch
2 times, most recently
from
608d253 to
2644953
Compare
| @u.print_test_decorator | ||
| def run_test_windows(remote_host: u.Host, env_vars: dict) -> None: | ||
| init_command = r'Set-Location "C:\Program Files\Observe\observe-agent"; ./observe-agent init-config --token {} --observe_url {} --cloud_resource_detectors ec2'.format( | ||
| def init_config_command(env_vars: dict) -> str: |
There was a problem hiding this comment.
This change sets a resource attribute in the config for all tests. I had some yaml spacing issues in my diff originally, so I added extra logging; that is why the test files have other changes.
integration/scripts/test_start.py
Outdated
| @@ -65,7 +66,7 @@ def run_test_windows(remote_host: u.Host, env_vars: dict) -> None: | |||
| # status | |||
| start_command = r".\start_agent_windows.ps1" | |||
| status_command = r'Get-Service ObserveAgent;Set-Location "${Env:Programfiles}\Observe\observe-agent"; ./observe-agent status' | |||
| start_timeout = 30 # how long to wait for observe-agent to start | |||
| start_timeout = 10 # how many times to check for the running agent | |||
There was a problem hiding this comment.
is this how many times we check? is start_timeout not a correct variable name?
There was a problem hiding this comment.
Good point, I renamed this and added/used a default value at the call sites.
| {{- range $key, $value := .Attributes }} | ||
| - key: {{ $key }} | ||
| value: {{ $value }} | ||
| action: insert |
There was a problem hiding this comment.
i think maybe this might need to be overrideable as well, upsert is potentially a desired value
obs-gh-mattcotter
force-pushed
the
mc/agent-attributes
branch
from
2644953 to
faaccd2
Compare
obs-gh-alexlew
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OB-44816 Add config option to set generic attributes or resource attributes. This is needed to configure service explorer attributes when running on a host.
Checklist