Skip to content

feat: use agent config for init-config command future proofing #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025

Conversation

obs-gh-mattcotter
Copy link
Collaborator

Description

Use agent config for init-config command. This allows all values in the agent config to work with this command both currently and going forward.

Ex:

$ OBSERVE_URL="http://observeinc.com/" ./observe-agent --observe-config=./empty.yaml init-config --print 2>/dev/null
# Observe data token
token: ""

# Target Observe collection url
observe_url: http://observeinc.com/

health_check:
    enabled: true
    endpoint: localhost:13133
    path: /status

forwarding:
    enabled: true

internal_telemetry:
    enabled: true
    host: localhost
    port: 8888

# otel_config_overrides:
#   exporters:
#     debug:
#       verbosity: detailed
#       sampling_initial: 5
#       sampling_thereafter: 200
#   service:
#     pipelines:
#       metrics:
#         receivers: [hostmetrics]
#         processors: [memory_limiter]
#         exporters: [debug]

Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

Base automatically changed from mc/config-defaults to main April 22, 2025 18:31
@obs-gh-mattcotter obs-gh-mattcotter force-pushed the mc/init-config-improvements branch from e3504b0 to f56c83e Compare April 22, 2025 18:36
Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@obs-gh-mattcotter obs-gh-mattcotter force-pushed the mc/init-config-improvements branch from f56c83e to c8e4d42 Compare April 22, 2025 18:44
@obs-gh-mattcotter obs-gh-mattcotter merged commit e1c6d40 into main Apr 22, 2025
12 checks passed
@obs-gh-mattcotter obs-gh-mattcotter deleted the mc/init-config-improvements branch April 22, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants