-
Notifications
You must be signed in to change notification settings - Fork 1
feat: add config command flag --render-otel to print full otel config #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
37e628e
to
c71b0b2
Compare
how is this different from the |
Good question! The |
…d --render-otel-details
Updated to use flags instead of a new sub command. |
internal/commands/config/config.go
Outdated
colSettings := observecol.GenerateCollectorSettingsWithConfigFiles(configFilePaths) | ||
factories, err := colSettings.Factories() | ||
if err != nil { | ||
return fmt.Errorf("failed to initialize factories: %w", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: are we initializing or just retrieving the existing factories?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, we're initializing the maps. I rephrased this to say: "failed to create component factory maps"
540cc3d
to
b85382d
Compare
Description
Add the flags
--render-otel
and--render-otel-details
to theconfig
command to print full otel config. This short version is modeled after theotelcol print
command, the long version was modeled after the startup command.Ex:
vs