fix: use .Tag in goreleaser tag template #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obs-gh-alexlew
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using
{{ .CurrentTag }}failed in the latest release: https://github.com/observeinc/observe-agent/actions/runs/13976540750/job/39131810187CurrentTagcame from the goreleaser release github docs: https://goreleaser.com/customization/release/#githubLooking at the code, I wonder if the actual value ought to be
{{ .Git.CurrentTag }}. But there are no uses ofCurrentTagin templates in their repo.Many of their tests reference
Tag, which is detailed in the docs here: https://goreleaser.com/customization/templates/#common-fieldsI was convinced by the use of
Tagin their tests, so that's what I decided to try first. Unfortunately thisrelease.tagfeature is only available in pro, so I can't read the code and find the answer that way.