Skip to content

fix: add go mod replacements for vulnerable dependencies #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 19, 2025
Merged

fix: add go mod replacements for vulnerable dependencies #178

merged 4 commits into from
Mar 19, 2025

Conversation

obs-gh-mattcotter
Copy link
Collaborator

Description

Add go mod replacements for vulnerable dependencies.
This addresses issues found here: https://github.com/observeinc/observe-agent/actions/runs/13932332963

@obs-gh-alexlew
Copy link
Collaborator

hmm you actually can't run the vuln check against a branch huh? it'd be useful here to confirm this actually resolves the issues

@obs-gh-alexlew
Copy link
Collaborator

can you fix the medium golang.org/x/net vuln too?

@obs-gh-mattcotter
Copy link
Collaborator Author

hmm you actually can't run the vuln check against a branch huh? it'd be useful here to confirm this actually resolves the issues

Good point! I updated the action in this PR.

@obs-gh-mattcotter
Copy link
Collaborator Author

hmm you actually can't run the vuln check against a branch huh? it'd be useful here to confirm this actually resolves the issues

Good point! I updated the action in this PR.

Verified here: https://github.com/observeinc/observe-agent/actions/runs/13951985810
All but the unfixed Medium and Low issues are resolved by this PR.

obs-gh-alexlew
obs-gh-alexlew reviewed Mar 19, 2025
View reviewed changes
.github/workflows/vuln-check.yaml Outdated
@@ -2,7 +2,16 @@ name: Docker Image Vulnerability Check

on:
workflow_dispatch:
inputs:
branch:
description: "The branch to create nightly release based on"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description is incorrect

obs-gh-alexlew
obs-gh-alexlew approved these changes Mar 19, 2025
View reviewed changes
Copy link
Collaborator

@obs-gh-alexlew obs-gh-alexlew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small fix to description of input, otherwise lgtm

@obs-gh-mattcotter obs-gh-mattcotter merged commit 6491512 into main Mar 19, 2025
8 checks passed
@obs-gh-mattcotter obs-gh-mattcotter deleted the mc/vulns branch March 19, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obs-gh-alexlew obs-gh-alexlew obs-gh-alexlew approved these changes

Assignees

@obs-gh-alexlew obs-gh-alexlew

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@obs-gh-mattcotter @obs-gh-alexlew