Skip to content

feat: add default batch timeout of 5s #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025
Merged

Conversation

obs-gh-mattcotter
Copy link
Collaborator

@obs-gh-mattcotter obs-gh-mattcotter commented Mar 14, 2025

Description

Add default batch timeout of 5s to reduce number of requests.

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

@obs-gh-jabernet
Copy link
Collaborator

https://docs.observeinc.com/en/latest/content/data-ingestion/endpoints/otel.html ; Our per request limit is 50mb uncompressed. So we could have significantly higher thresholds assuming 1kb log lines. Maybe we should just set both values to the default send_batch_size of 8192 for now and we can tune it in another PR based on data from O2?

@obs-gh-mattcotter obs-gh-mattcotter changed the title feat: add default batch timeout of 5s and set batch sizing to increase chances of staying within our API limits feat: add default batch timeout of 5s Mar 17, 2025
@obs-gh-mattcotter
Copy link
Collaborator Author

https://docs.observeinc.com/en/latest/content/data-ingestion/endpoints/otel.html ; Our per request limit is 50mb uncompressed. So we could have significantly higher thresholds assuming 1kb log lines. Maybe we should just set both values to the default send_batch_size of 8192 for now and we can tune it in another PR based on data from O2?

I have updated this PR to only set the timeout and leave the sizing values as default. Thanks!

@obs-gh-mattcotter obs-gh-mattcotter merged commit fe95c22 into main Mar 17, 2025
8 checks passed
@obs-gh-mattcotter obs-gh-mattcotter deleted the mc/batch-processor branch March 17, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants