fix: fix whitespace typo when customizing CloudResourceDetectors #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obs-gh-mattcotter
force-pushed
the
mc/cloud-resource
branch
from
b45cf96 to
043bad2
Compare
| @@ -31,7 +31,7 @@ def run_test_docker(remote_host: u.Host, env_vars: dict) -> None: | |||
|
|
|||
| @u.print_test_decorator | |||
| def run_test_linux(remote_host: u.Host, env_vars: dict) -> None: | |||
| init_command = "sudo observe-agent init-config --token {} --observe_url {}".format( | |||
| init_command = "sudo observe-agent init-config --token {} --observe_url {} --cloud_resource_detectors ec2".format( | |||
There was a problem hiding this comment.
if i want to configure multiple detectors do i provide this flag multiple times?
There was a problem hiding this comment.
Yes, you can specify multiple times or use comma separated values. I added a --print flag to illustrate this:
$ ./observe-agent init-config --print --cloud_resource_detectors gcp --cloud_resource_detectors ecs --cloud_resource_detectors 1,2,3
# Observe data token
token: ...
# Target Observe collection url
observe_url: ...
# Debug mode - Sets agent log level to debug
debug: false
cloud_resource_detectors:
- gcp
- ecs
- 1
- 2
- 3
# ...
obs-gh-mattcotter
force-pushed
the
mc/cloud-resource
branch
from
e990810 to
180ba0a
Compare
obs-gh-alexlew
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix whitespace typo when customizing CloudResourceDetectors. Before this change, the generated config was
detectors:[ec2]instead ofdetectors: [ec2]Checklist