fix: Override log body with structured object #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obs-gh-enricogiorio
force-pushed
the
enrico/refactorTest
branch
2 times, most recently
from
9d48226 to
8b17349
Compare
Currently we were modifying the marshalled k8s object and then overriding the log body with its unmarshalled string representation. This doesn't work well when the custom processor is not last in the pipeline, because other processors might have to index into the structured body to be able to extract values. Since we need to move the transform processor after the custom processor in the agent configmap, we want to make sure that this processor leaves the log body as a structured object, rather than a plain string.
obs-gh-enricogiorio
force-pushed
the
enrico/refactorTest
branch
from
8b17349 to
65fada0
Compare
xueweiz
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we were modifying the marshalled k8s object and then overriding the log body with its unmarshalled string representation.
This doesn't work well when the custom processor is not last in the pipeline, because other processors might have to index into the structured body to be able to extract values.
Since we need to move the transform processor after the custom processor in the agent configmap, we want to make sure that this processor leaves the log body as a structured object, rather than a plain string.
Description
OB-XXX Please explain the changes you made here.
Checklist