Skip to content

feat: validate the otel configuration in diagnose #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 28, 2024
Merged

feat: validate the otel configuration in diagnose #116

merged 2 commits into from
Oct 28, 2024

Conversation

obs-gh-mattcotter
Copy link
Collaborator

@obs-gh-mattcotter obs-gh-mattcotter commented Oct 25, 2024 •
edited
Loading

Description

OB-31850 Validate all OTEL configuration in the diagnose command

Example output:

⚠️ OTEL configuration validation failed with error service::pipelines::metrics: references receiver "filelog" which is not configured

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

obs-gh-alexlew
obs-gh-alexlew reviewed Oct 25, 2024
View reviewed changes
internal/commands/diagnose/otelconfigcheck.go
if err != nil {
return nil, err
}
err = col.DryRun(context.Background())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just for my info, can you link to the implementation of DryRun in the otel code

@obs-gh-mattcotter obs-gh-mattcotter force-pushed the OB-31850-diagnose-config-issues branch from 966ba0d to a200f55 Compare October 28, 2024 16:54
Base automatically changed from OB-31850-diagnose-config-issues to main October 28, 2024 17:28
@obs-gh-mattcotter obs-gh-mattcotter force-pushed the OB-31850-diagnose-otel-config branch from 4682518 to a1532ba Compare October 28, 2024 20:00
@obs-gh-mattcotter obs-gh-mattcotter merged commit d637b49 into main Oct 28, 2024
8 checks passed
@obs-gh-mattcotter obs-gh-mattcotter deleted the OB-31850-diagnose-otel-config branch October 28, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obs-gh-alexlew obs-gh-alexlew obs-gh-alexlew approved these changes

Assignees

@obs-gh-alexlew obs-gh-alexlew

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@obs-gh-mattcotter @obs-gh-alexlew